Forum: Ruby-core Patch for : ext\dl\handle.c

Posted by Christian Bodt (Guest)
on 2010-03-05 14:24
Attachment: simpler_dlerror_check.patch (1,7 KB)
(Received via mailing list)
Hi,

It's the first time I try to contribute to the ruby project.
I'd like to propose this small patch to make the dlhandle_sym function a
little more readable.
     * ext/dl/handle.c (dlhandle_sym): Added xdlsym function and 
replaced
CHECK_DLERROR with 'xdlsym'

Initially, I wanted to add the support for loading of symbols with the
format "_function@NNN" (from MSCV dlls) but the "dlhandle_sym" function 
was
a little to complex to implement it without some refactoring. I will 
need
some more patches to achieve this :)

I tried to keep this patch very simple.
What do you think?

Christian Bodt
Posted by Nobuyoshi Nakada (nobu)
on 2010-03-05 16:29
(Received via mailing list)
Hi,

At Fri, 5 Mar 2010 22:24:01 +0900,
Christian Bodt wrote in [ruby-core:28504]:
> Initially, I wanted to add the support for loading of symbols with the
> format "_function@NNN" (from MSCV dlls) but the "dlhandle_sym" function was
> a little to complex to implement it without some refactoring. I will need
> some more patches to achieve this :)

It's already supported.
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.