Forum: IronRuby Code Review: MiscStrings

Posted by Tomas Matousek (Guest)
on 2010-03-02 03:31
Attachment: MiscStrings.diff (73,7 KB)
(Received via mailing list)
tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

A simple DLR Console Shell change:
The version printed by the console host now recognizes Mono correctly.

Ruby changes:
Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
Fixes -d and --version options.
Fixes a bug in StringScanner: scan doesn't copy the original string and 
[] uses the current value.
Makes MutableString.GetSlice out-of-range tolerant (needed by 
StringScanner#[] fix).
Improves performance of repeated Regex.Match called on the same input 
string.

Tomas
Posted by Jim Deville (Guest)
on 2010-03-05 11:29
(Received via mailing list)
Ruby tests are fine.

JD

_____________________________________________
From: Dino Viehland
Sent: Wednesday, March 03, 2010 11:29 AM
To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code 
Reviewers
Cc: ironruby-core@rubyforge.org
Subject: RE: Code Review: MiscStrings


DLR change looks fine.

      _____________________________________________
      From: Tomas Matousek
      Sent: Monday, March 01, 2010 6:30 PM
      To: IronRuby External Code Reviewers; Rowan Code Reviewers
      Cc: ironruby-core@rubyforge.org
      Subject: Code Review: MiscStrings


        tfpt review "/shelveset:MiscStrings;REDMOND\tomat"

      A simple DLR Console Shell change:
      The version printed by the console host now recognizes Mono 
correctly.

      Ruby changes:
      Ignores UTF8 BOM in 1.8 mode unless $KCODE is SJIS or EUC.
      Fixes 
http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=3913
      Fixes -d and --version options.
      Fixes a bug in StringScanner: scan doesn't copy the original 
string and [] uses the current value.
      Makes MutableString.GetSlice out-of-range tolerant (needed by 
StringScanner#[] fix).
      Improves performance of repeated Regex.Match called on the same 
input string.

      Tomas


       << File: MiscStrings.diff >>
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.