Forum: JRuby rcov report includes jruby core classes

When I run rcov using jruby, my reports contain all of the jruby core
classes along with strange classes like (eval),
(recognized_optimized), (erb), and others.  The same thing does not
occur when i switch over to c ruby.  Anyone else have this
experience?  I tried explicitly including the app directory with "--
include app" but this doesn't seem to help eliminate the extra
libraries.

thx.

-karl

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

We run rcov with this option to clear out most of the cruft:

--exclude 
"rubygems/*,jruby/*,parser*,gemspec*,_DELEGATION*,eval*,recognize_optimized*,yaml,yaml/*,fcntl,(__FORWARDABLE__),(erb),teamcity/*,<script>"


-Justin

On Wed, Feb 17, 2010 at 10:17 PM, Karl Baum <karl.baum@gmail.com> wrote:
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>   http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

Why I don't get is:

1)  Why can't we just specify --include so we don't have to specify
all of this junk :-).
2)  Why does this happen in jruby only?

Thanks for your help!

-karl
On Feb 18, 2010, at 12:24 AM, Justin Coyne wrote:

> wrote:
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

The why is a little involved.  in generating code using eval, jruby
creates filenames like you mentioned and the way these files get
generated triggers teh RCov hooks and RCov says "Oh here are some more
files" and adds them to the list of files being monitored.

I was thinking of automatically opting out on some of these files but
I don't have a complete list of them yet (I can pull most of em out of
the jruby source tho).  I am also trying to track down(although I
haven't had much time lately) an issue with how RCov reports coverage
on partials in rails.  And I'm not convinced the 2 are unrelated yet.
In rails projects I've tested RCov with Rcov reports coverage of
partials in jruby but not in ruby.


So I guess the answer is ... I want to clean that stuff up.  I have
cleared some time next week to work on these issues so I'll keep you
posted.

Jay


On Thu, Feb 18, 2010 at 6:40 AM, Karl Baum <karl.baum@gmail.com> wrote:
>
>>> When I run rcov using jruby, my reports contain all of the jruby core
>>> -karl
>> To unsubscribe from this list, please visit:
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

I feel reassured I wasn't doing something wrong now :-).  Thanks for
the update!

-karl

On Feb 18, 2010, at 8:18 AM, Jay McGaffigan wrote:

> In rails projects I've tested RCov with Rcov reports coverage of
> On Thu, Feb 18, 2010 at 6:40 AM, Karl Baum <karl.baum@gmail.com>  
>> -karl
>>>
>>>> over to c
>>>>
>>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
>    http://xircles.codehaus.org/manage_email
>
>


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

On Thu, Feb 18, 2010 at 7:18 AM, Jay McGaffigan <hooligan495@gmail.com> 
wrote:
> In rails projects I've tested RCov with Rcov reports coverage of
> partials in jruby but not in ruby.
>
>
> So I guess the answer is ... I want to clean that stuff up.  I have
> cleared some time next week to work on these issues so I'll keep you
> posted.

Is this something we shouldn't be doing in JRuby? For example, should
we not be tracing code within evals?

To be honest, the JRuby behavior seems *more* correct, since we're
showing all code, even if it's "anonymous". But if there's something
we should or should not be doing, please let me know. (and of course I
know you will)

- Charlie

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email

In my opinion I Like seeing this code.   I think opting out of seeing
this code in your RCov reports is better (or making RCov by default
not include them)  I suspect that this is what let's me see coverage
of rails partials in my Jruby on Rails app (I don't see it in MRI).

Just my 0.02

Jay

On Tue, Mar 2, 2010 at 2:53 PM, Charles Oliver Nutter
<headius@headius.com> wrote:
>> on partials in rails.  And I'm not convinced the 2 are unrelated yet.
>
>    http://xircles.codehaus.org/manage_email
>
>
>

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email