Forum: Ruby-core [Feature #2480] request to add GC::Profiler.time method

Feature #2480: request to add GC::Profiler.time method
http://redmine.ruby-lang.org/issues/show/2480

Author: Roger Pack
Status: Open, Priority: Normal

currently we have
GC::Profiler.enable
# ... stuff
report = GC::Profiler.result # report is set to a verbose ascii string

What I would like is to be able to add garbage time to profiling 
information [i.e. "within this method, of the total time that was used, 
GC took 42ms")

GC::Profiler.time
=> float of the total time used (ms).

or could call it time_used or total_time or whatever.

Then it would make adding GC time to profiler time much faster, as I 
wouldn't have to parse the result output each time to calculate my own 
total (it would just be a matter of calling Profiler.time, seeing if the 
time has increased since last setting).

Thanks.
-r

Issue #2480 has been updated by Yusuke Endoh.

Category deleted (core)
Status changed from Assigned to Open
Assigned to deleted (Narihiro Nakamura)
Target version deleted (1.9.x)

Hi,

> What I would like is to be able to add garbage time to profiling information [i.e. "within this method, of the total time that was used, GC took 42ms")


If anyone (nari?) writes a patch, it can be accepted and committed
because no one has disagreed, I guess.

--
Yusuke Endoh <mame@tsg.ne.jp>
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2480

Issue #2480 has been updated by _ wanabe.

File gc_prof_totaltime.patch added

I wrote a patch.
If it is OK, I'll commit later.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2480

Hi,

2010/3/3 _ wanabe <redmine@ruby-lang.org>:
> File gc_prof_totaltime.patch added
>
> I wrote a patch.
> If it is OK, I'll commit later.

+1

The name `total_time' is also good for me.

Hi,

>> I wrote a patch.
>> If it is OK, I'll commit later.
>
> +1
>
> The name `total_time' is also good for me.
>

Me, too.

Issue #2480 has been updated by _ wanabe.

Status changed from Assigned to Closed

Applied at r26814. Thank you.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2480

Issue #2480 has been updated by Roger Pack.


Many thanks.  I will use this in the ruby-prof gem most likely, for more 
intuitive profiling.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2480