Forum: Typo Ruby 1.9 questions

Hi,

I forked a copy of typo last night and dove in trying to make it work
with Ruby 1.9 and I have a few questions that I probably should know
the answers to but I don't... sorry.

First, the code in vendor/plugins... are they plugins or are they part
of typo?  I don't know much how git works with submodules.  I've heard
the term but that is about it.  Many of the changes are hitting the
plugins.

Second, am I the first explore of these here Typo, Ruby 1.9
netherlands?  Anyone wanna combine efforts?

Thanks,
Perry
Ease Software, Inc. ( http://www.easesoftware.com )

Low cost SATA Disk Systems for IBMs p5, pSeries, and RS/6000 AIX systems

Perry Smith a écrit :
> Hi,
>
> I forked a copy of typo last night and dove in trying to make it work
> with Ruby 1.9 and I have a few questions that I probably should know
> the answers to but I don't... sorry.
>
> First, the code in vendor/plugins... are they plugins or are they part
> of typo?  I don't know much how git works with submodules.  I've heard
> the term but that is about it.  Many of the changes are hitting the
> plugins.
We don't have some submodule now.

All plugins are come from other project
>
> Second, am I the first explore of these here Typo, Ruby 1.9
> netherlands?  Anyone wanna combine efforts?

Rails 2.3.4 is not fullfuly ruby 1.9 compatible. So I think you can have
some issue from Rails :(

--
Cyril Mougel
http://blog.shingara.fr/

Perry Smith wrote:
> Second, am I the first explore of these here Typo, Ruby 1.9
> netherlands?  Anyone wanna combine efforts?

I have pretty much finished porting to 1.9.1 but to get things working I
needed to patch soap4r[1] actionwebservice[2] the mysql-ruby[3] driver,
and actionpack to get things working.  It also seems to be using about
70M as appose to 50M on 1.8.  A lot of things aren't handling 1.9 string
encodings properly and most of the proposed patches are nasty hack that
just override the results rather then fixing the cause of the problem.

Edward

1. http://github.com/emiddleton/soap4r
2. http://github.com/emiddleton/actionwebservice
3. http://github.com/emiddleton/mysql-ruby

--- ./actionpack-2.3.4.orig/lib/action_view/template_handlers/erb.rb
2009-09-04 23:09:20.043938934 +0900
+++ ./actionpack-2.3.4/lib/action_view/template_handlers/erb.rb
2009-10-05 00:28:13.000000000 +0900
@@ -15,8 +15,24 @@

         # Ruby 1.9 prepends an encoding to the source. However this is
         # useless because you can only set an encoding on the first 
line
-        RUBY_VERSION >= '1.9' ? src.sub(/\A#coding:.*\n/, '') : src
+        if RUBY_VERSION >= '1.9'
+          enc = detect_magic_comment(template.source) ||
Encoding.find('UTF-8')
+          src.force_encoding(enc).sub(/\A#coding:.*\n/, '')
+        else
+          src
+        end
       end
+      private
+        def detect_magic_comment(s)
+          if /\A<%#(.*)%>/ =~ s or (@percent and /\A%#(.*)/ =~ s)
+            comment = $1
+            comment = $1 if comment[/-\*-\s*(.*?)\s*-*-$/]
+            if %r"coding\s*[=:]\s*([[:alnum:]\-_]+)" =~ comment
+              enc = $1.sub(/-(?:mac|dos|unix)/i, '')
+              enc = Encoding.find(enc)
+            end
+          end
+        end
     end
   end
 end

On Oct 5, 2009, at 9:30 AM, Cyril Mougel wrote:
>
> Rails 2.3.4 is not fullfuly ruby 1.9 compatible. So I think you can  
> have
> some issue from Rails :(

Really?  I thought it was.

On Oct 5, 2009, at 9:42 AM, Edward Middleton wrote:

> Perry Smith wrote:
>> Second, am I the first explore of these here Typo, Ruby 1.9
>> netherlands?  Anyone wanna combine efforts?
>
> I have pretty much finished porting to 1.9.1 but

Cool... your typo repository looks a bit stale right now.  Do you plan
to push your changes up soon?

Perry Smith wrote:
> Edward Middleton wrote:
>> Perry Smith wrote:
>>> Second, am I the first explore of these here Typo, Ruby 1.9
>>> netherlands?  Anyone wanna combine efforts?
>>
>> I have pretty much finished porting to 1.9.1 but
> 
> Cool... your typo repository looks a bit stale right now.  Do you plan
> to push your changes up soon?

Will do when I get a chance, though I am heading to bed now because its
12:00am here ;)

Edward

Edward Middleton wrote:
> Perry Smith wrote:
>> Edward Middleton wrote:
>>> Perry Smith wrote:
>>>> Second, am I the first explore of these here Typo, Ruby 1.9
>>>> netherlands?  Anyone wanna combine efforts?
>>> I have pretty much finished porting to 1.9.1 but
>> Cool... your typo repository looks a bit stale right now.  Do you plan
>> to push your changes up soon?
> 
> Will do when I get a chance,

Rather then put it off for longer I have pushed most/all of my changes
for 1.9.1 support[1].  It needs my forked versions of mysql-ruby, soap4r
and actionwebservices.

Edward

1. http://github.com/emiddleton/typo/commits/ruby_1_9

This isn't necessarily typo related but I was just viewing the official 
blog and noticed the category list on the right side nav is not working. 
Goes straight to Application error (Apache)

http://blog.typosphere.org/category/general

Le 15 déc. 2009 à 15:07, Zach Karpinski a écrit :

> This isn't necessarily typo related but I was just viewing the official blog and noticed the category list on the right side nav is not working.  Goes straight to Application error (Apache)
> 
> http://blog.typosphere.org/category/general


Hello,

Sorry for late reply, just seen that mail.
We had a caching issue that was solved by manually removing the cache.

Thank you for telling us about it
Regards,
Frédéric

--
Frédéric de Villamil
"What's mine is mine. What's yours is still unsetteled" – Go player 
proverb
frederic@de-villamil.com                        tel: +33 (0)6 62 19 1337
http://t37.net                       Typo : http://typosphere.org