Forum: IronRuby Review: Misc ActiveRecord bug fixes

Posted by Shri Borde (Guest)
on 2009-06-26 23:28
(Received via mailing list)
Thanks to Ray and Joshua for pair debugging this morning!

http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029

Module#autoload call should be ignored if the constant is defined. 
Without this, a class definition was being lost if autoload was called 
after the class definition was executed
(timeObj == "string") should return nil. It was throwing TypeError 
because method overload resolution was finding 
System.DateTime.op_Equality. Throwing a TypeError is ok for .NET types 
with strongly typed op_Equality, but not for those types that represent 
Ruby types.
Fix typo in multi-line regex in YAML engine causing incorrect parsing of 
Time yaml strings

 * 
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-0>
 * 
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/autoload_spec.rb<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-1>
 * 
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/time/eql_spec.rb<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-2>
 * 
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/time/equal_value_spec.rb<http://github.com/shri/ironruby/tree/226ceebdd8e64fc86042e626b9de1e96b4226029/Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/time/equal_value_spec.rb>
 * 
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-4>
 * 
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/TimeOps.cs<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-5>
 * 
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-6>
 * 
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyModule.cs<http://github.com/shri/ironruby/commit/226ceebdd8e64fc86042e626b9de1e96b4226029#diff-7>
Thanks,
Shri
Please log in before posting. Registration is free and takes only a minute.
Existing account (Switch to SSL-encrypted connection)
NEW: Do you have a Google/GoogleMail or Yahoo account? No registration required!
Log in with Google account | Log in with Yahoo account
No account? Register here.