Forum: IronRuby Review: File.expand_path

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-06-03 22:26
(Received via mailing list)
http://github.com/shri/ironruby/commit/ec9eae2e12e...

Reimplemented File.expand_path such that it does not use System.IO.Path.
This allows us to get better compatibility with MRI.
The motivating reason was that RSpec does
File.expand_path("filename:linenumber"), and the old implementation
complained that : is not valid in filenames, whereas MRI allows such
input

Fixed "[nil].uniq" - Cucumber was running into this.
Renamed scripts\ruby19.bat to ruby1.9.bat as "mspec -tr19" seems to have
changed.

List of files:

 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/array/uniq_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Scripts/RakeTests.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
 *
Merlin/Main/Languages/Ruby/Scripts/ruby1.9.bat<http://github.com/shri/ironruby/tree/ec9eae2e12e97...
 *   Merlin/Main/Languages/Ruby/Scripts/ruby19.bat
 *
Merlin/Main/Runtime/Microsoft.Scripting/Utils/ArrayUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
Thanks,
Shri
Jimmy S. (Guest)
on 2009-06-03 22:28
(Received via mailing list)
Looks good.

From: Shri B.
Sent: Wednesday, June 03, 2009 11:07 AM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Review: File.expand_path

http://github.com/shri/ironruby/commit/ec9eae2e12e...

Reimplemented File.expand_path such that it does not use System.IO.Path.
This allows us to get better compatibility with MRI.
The motivating reason was that RSpec does
File.expand_path("filename:linenumber"), and the old implementation
complained that : is not valid in filenames, whereas MRI allows such
input

Fixed "[nil].uniq" - Cucumber was running into this.
Renamed scripts\ruby19.bat to ruby1.9.bat as "mspec -tr19" seems to have
changed.

List of files:

  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/array/uniq_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Dir.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Scripts/RakeTests.rb<http://github.com/shri/ironruby/commit/ec9eae2e12e...
  *
Merlin/Main/Languages/Ruby/Scripts/ruby1.9.bat<http://github.com/shri/ironruby/tree/ec9eae2e12e97...
  *   Merlin/Main/Languages/Ruby/Scripts/ruby19.bat
  *
Merlin/Main/Runtime/Microsoft.Scripting/Utils/ArrayUtils.cs<http://github.com/shri/ironruby/commit/ec9eae2e12e...
Thanks,
Shri
This topic is locked and can not be replied to.