Forum: IronRuby Code Review: ClrInteropBugFixes

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Tomas M. (Guest)
on 2009-06-02 05:53
(Received via mailing list)
Attachment: ClrInteropBugFixes.diff (0 Bytes)
tfpt review "/shelveset:ClrInteropBugFixes;REDMOND\tomat"



Simple DLR changes



Ruby bug fixes:

http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
load_assembly(<partial_name>) should work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
WinForms broken
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
System.Action.new does not work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo... Passing
a Ruby array to a .NET method that expects an IEnumerable derivative
fails with GetEnumerator call

+ fixes incorrect caching of TypeGroup#new.

Class#clr_member no longer throws an exception if called on Ruby class -
it returns a group of all inherited CLR methods of given name (if there
are any).
Improves display name of generic types: e.g. Action<int> displays as
System::Action[Fixnum].



Tomas
Tomas M. (Guest)
on 2009-06-02 06:12
(Received via mailing list)
Adding one more bug fix:

http://ironruby.codeplex.com/WorkItem/View.aspx?Wo... : Can't
call the BigIntegerOverload of a method with a DefaultProtocol Attribute
on the BigInteger attribute

+ Bignum.new(1) should call method_missing:

irb(main):001:0> Bignum.new(1)
NoMethodError: undefined method `new' for Bignum:Class

Tomas

From: Tomas M.
Sent: Monday, June 01, 2009 6:47 PM
To: IronRuby External Code R.; Rowan Code R.
Cc: removed_email_address@domain.invalid
Subject: Code Review: ClrInteropBugFixes


tfpt review "/shelveset:ClrInteropBugFixes;REDMOND\tomat"



Simple DLR changes



Ruby bug fixes:

http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
load_assembly(<partial_name>) should work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
WinForms broken
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
System.Action.new does not work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo... Passing
a Ruby array to a .NET method that expects an IEnumerable derivative
fails with GetEnumerator call

+ fixes incorrect caching of TypeGroup#new.

Class#clr_member no longer throws an exception if called on Ruby class -
it returns a group of all inherited CLR methods of given name (if there
are any).
Improves display name of generic types: e.g. Action<int> displays as
System::Action[Fixnum].



Tomas
Curt H. (Guest)
on 2009-06-02 20:29
(Received via mailing list)
Looks good!

From: Tomas M.
Sent: Monday, June 01, 2009 7:06 PM
To: Tomas M.; IronRuby External Code R.; Rowan Code
Reviewers
Cc: removed_email_address@domain.invalid
Subject: RE: Code Review: ClrInteropBugFixes

Adding one more bug fix:

http://ironruby.codeplex.com/WorkItem/View.aspx?Wo... : Can't
call the BigIntegerOverload of a method with a DefaultProtocol Attribute
on the BigInteger attribute

+ Bignum.new(1) should call method_missing:

irb(main):001:0> Bignum.new(1)
NoMethodError: undefined method `new' for Bignum:Class

Tomas

From: Tomas M.
Sent: Monday, June 01, 2009 6:47 PM
To: IronRuby External Code R.; Rowan Code R.
Cc: removed_email_address@domain.invalid
Subject: Code Review: ClrInteropBugFixes


tfpt review "/shelveset:ClrInteropBugFixes;REDMOND\tomat"



Simple DLR changes



Ruby bug fixes:

http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
load_assembly(<partial_name>) should work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
WinForms broken
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
System.Action.new does not work
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo... Passing
a Ruby array to a .NET method that expects an IEnumerable derivative
fails with GetEnumerator call

+ fixes incorrect caching of TypeGroup#new.

Class#clr_member no longer throws an exception if called on Ruby class -
it returns a group of all inherited CLR methods of given name (if there
are any).
Improves display name of generic types: e.g. Action<int> displays as
System::Action[Fixnum].



Tomas
This topic is locked and can not be replied to.