Forum: IronRuby Review: Rake bug fixes

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-05-13 03:48
(Received via mailing list)
http://github.com/shri/ironruby/commit/94a7a95fb6e...


*         Changed some uses of MutableString.Empty (like Array#join with
empty array) to create a new empty string as the user could validly
mutate it.

-          Renamed MutableString.Empty to MutableString.FixedEmpty to
make it clear that the instance should be shared in limited scenarios

*         Fixes to Module#instance_method per Tomas's feedback from
previous code review

*         File.extname(".foo") should return "", not ".foo"

*         Removes to_proc hack from Libs\hacks.rb

Files changed

 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/extname_tags.txt
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/split_tags.txt<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/module/instance_method_tags.txt<http://github.com/shri/ironruby/tree/94a7a95fb6eba...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/extname_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/split_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/classes.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/instance_method_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ModuleOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/MutableStringOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/UnboundMethod.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/ParseTree/IronRubyParseTreeOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/StringScanner/StringScanner.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libs/hacks.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/MatchData.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/MutableString.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyClass.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyModule.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Scripts/irtests.bat<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
Thanks,
Shri
Tomas M. (Guest)
on 2009-05-14 01:14
(Received via mailing list)
Looks good!

Tomas

From: Shri B.
Sent: Tuesday, May 12, 2009 4:48 PM
To: removed_email_address@domain.invalid; IronRuby External Code R.
Subject: Review: Rake bug fixes

http://github.com/shri/ironruby/commit/94a7a95fb6e...


*         Changed some uses of MutableString.Empty (like Array#join with
empty array) to create a new empty string as the user could validly
mutate it.

-          Renamed MutableString.Empty to MutableString.FixedEmpty to
make it clear that the instance should be shared in limited scenarios

*         Fixes to Module#instance_method per Tomas's feedback from
previous code review

*         File.extname(".foo") should return "", not ".foo"

*         Removes to_proc hack from Libs\hacks.rb

Files changed

 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/extname_tags.txt
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/split_tags.txt<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/module/instance_method_tags.txt<http://github.com/shri/ironruby/tree/94a7a95fb6eba...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/extname_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/split_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/classes.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/instance_method_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ModuleOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/MutableStringOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/UnboundMethod.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Extensions/IListOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/ParseTree/IronRubyParseTreeOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/StringScanner/StringScanner.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Libs/hacks.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/MatchData.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/MutableString.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyClass.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyModule.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyOps.cs<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Scripts/irtests.bat<http://github.com/shri/ironruby/commit/94a7a95fb6e...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/94a7a95fb6e...
Thanks,
Shri
This topic is locked and can not be replied to.