Forum: IronRuby Review: ActiveSupport bug fixes

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-05-11 21:17
(Received via mailing list)
http://github.com/shri/ironruby/commit/31d3ab9297e...

    Implement File.chown. It is a nop (on Windows)
    ObjectSpace.each_byte:
     It was not throwing an exception for the unsupported cases.
     Also, the unsupported cases should throw RuntimeError to match
ActiveSupport/JRuby conventions
     The return value was also incorrect
    NameError should call #inspect on self, not #to_s
    #instance_method on singleton classes behaves a bit differently - it
puts a contraint of the nominal type.
    UnboundMethod#bind was doing an incorrect type check and not dealing
with singleton classes. Factored out RubyContext.IsKindOf for this

Files changed:


 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/chown_tags.txt
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/name_error_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/classes.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/instance_method_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ModuleOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ObjectSpace.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/UnboundMethod.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyClass.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/Calls/ProtocolConversionAction.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyContext.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyExceptions.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...

Also added mocha gem :
http://github.com/shri/ironruby/commit/bdaf0adb28e...

Thanks,
Shri
Tomas M. (Guest)
on 2009-05-12 07:04
(Received via mailing list)
NominalClass is already implemented by GetNonSingletonClass(). The
difference is that GetNonSingletonClass() finds the first non-singleton
class in hierarchy. For object singletons this is the immediate
_superClass but for class/module singletons the super is also a
singleton. Have you tried how UnboundMethod#bind works on them?

Tomas

From: Shri B.
Sent: Monday, May 11, 2009 10:07 AM
To: removed_email_address@domain.invalid; IronRuby External Code R.
Subject: Review: ActiveSupport bug fixes

http://github.com/shri/ironruby/commit/31d3ab9297e...

    Implement File.chown. It is a nop (on Windows)
    ObjectSpace.each_byte:
     It was not throwing an exception for the unsupported cases.
     Also, the unsupported cases should throw RuntimeError to match
ActiveSupport/JRuby conventions
     The return value was also incorrect
    NameError should call #inspect on self, not #to_s
    #instance_method on singleton classes behaves a bit differently - it
puts a contraint of the nominal type.
    UnboundMethod#bind was doing an incorrect type check and not dealing
with singleton classes. Factored out RubyContext.IsKindOf for this

Files changed:


 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/chown_tags.txt
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/name_error_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/fixtures/classes.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/module/instance_method_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ModuleOps.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ObjectSpace.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/UnboundMethod.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/RubyClass.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/Calls/ProtocolConversionAction.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyContext.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Ruby/Runtime/RubyExceptions.cs<http://github.com/shri/ironruby/commit/31d3ab9297e...
 *
Merlin/Main/Languages/Ruby/Tests/Interop/uncategorized_spec.rb<http://github.com/shri/ironruby/commit/31d3ab9297e...

Also added mocha gem :
http://github.com/shri/ironruby/commit/bdaf0adb28e...

Thanks,
Shri
This topic is locked and can not be replied to.