Forum: IronRuby Code Review: Encodingsa1

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Tomas M. (Guest)
on 2009-05-08 03:14
(Received via mailing list)
Attachment: Encodingsa1.diff (0 Bytes)
tfpt review "/shelveset:EncodingsA1;REDMOND\tomat"
  Comment  :
  Implements IsAscii() on MutableString - the bit is calculated along
with hashcode and invalidated each time a mutable operation is
performed.
  Enables combination of mutable strings with different
encodings/KCoding. If a string is k-coded it should be treated as byte
array for all operations since 1.8 doesn't tag the strings with
encodings. Hence any k-coded strings can be combined regardless of their
actual encodings. 1.9-encoded strings must have the same encoding or one
of them must have all characters in range 0..127 (IsAscii == true) - MRI
1.9 allows combination of such strings.

  Fixes:
  -  "IronRuby ignores RUBYLIB environment variable"
http://ironruby.codeplex.com/WorkItem/View.aspx?Wo...
  -  Encoding wasn't flowing correctly in eval (test Encoding4)
  -  Improves performance of String#*.
  -  MutableString.Content.GetCapacity was wrong.

Tomas
This topic is locked and can not be replied to.