Forum: IronRuby Review: Misc fixes

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-04-14 09:14
(Received via mailing list)
http://github.com/shri/ironruby/commit/24ce7ba7cda...
GitDiff.bat 5e8c6b232a3c952985adbf1b9cda5c456d503cea
24ce7ba7cdac9a52d3f43dbd77300f5067d31ead


*         Fixes File.expand_path to workaround a problem "igem i rails"
was running into.

*         Fixes File apis to throw correct exception type

*         Implements Kernel.abort

*         Adds Errno::ECONNREFUSED

*         Exception#message should call Exception#to_s

*         Fixes paths in rbconfig.rb to work in dev environment

Files changed:

 *
.gitignore<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/tree/24ce7ba7cdac9...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/string/split_tags.txt<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/message_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/to_s_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/abort_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/string/split_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ExceptionOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/MutableStringOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Libs/rbconfig.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
 *
Merlin/Main/Languages/Ruby/Ruby/Builtins/File.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...

Thanks,
Shri
Jim D. (Guest)
on 2009-04-14 23:13
(Received via mailing list)
http://github.com/shri/ironruby/commit/24ce7ba7cda...

*         Undo this deletion. That is a valid spec as well.

http://github.com/shri/ironruby/commit/24ce7ba7cda...

*         Guards don't go inside of examples. Please split this into two
specs: one guarded, the other unguarded.

http://github.com/shri/ironruby/commit/24ce7ba7cda...

*         I would keep the :in_block in the spec to be sure that it
isn't a no-op

Test and .rb changes look good other than that.

JD

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Shri B.
Sent: Monday, April 13, 2009 10:14 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: [Ironruby-core] Review: Misc fixes

http://github.com/shri/ironruby/commit/24ce7ba7cda...
GitDiff.bat 5e8c6b232a3c952985adbf1b9cda5c456d503cea
24ce7ba7cdac9a52d3f43dbd77300f5067d31ead


*         Fixes File.expand_path to workaround a problem "igem i rails"
was running into.

*         Fixes File apis to throw correct exception type

*         Implements Kernel.abort

*         Adds Errno::ECONNREFUSED

*         Exception#message should call Exception#to_s

*         Fixes paths in rbconfig.rb to work in dev environment

Files changed:

  *
.gitignore<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/file/expand_path_tags.txt<http://github.com/shri/ironruby/tree/24ce7ba7cdac9...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/core/string/split_tags.txt<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/message_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/exception/to_s_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/rename_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/file/shared/unlink.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/abort_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/kernel/open_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/core/string/split_spec.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Errno.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/ExceptionOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/KernelOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/MutableStringOps.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Initializers.Generated.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Libs/rbconfig.rb<http://github.com/shri/ironruby/commit/24ce7ba7cda...
  *
Merlin/Main/Languages/Ruby/Ruby/Builtins/File.cs<http://github.com/shri/ironruby/commit/24ce7ba7cda...

Thanks,
Shri
This topic is locked and can not be replied to.