Forum: IronRuby Code Review: DefaultBinderRefactoring2

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Tomas M. (Guest)
on 2009-03-28 20:47
(Received via mailing list)
Attachment: DefaultBinderRefactoring2.diff (0 Bytes)
tfpt review "/shelveset:DefaultBinderRefactoring2;REDMOND\tomat"

Outer DLR, Python:

Refactors default method call binder:
-  Moves SiteLocalStorage to Python. Ruby uses a different storage class
and it's very simple for languages to define and use their own.
-  ActionBinder.BindSpecialParameter shouldn't deal with CodeContext and
SiteLocalStorage - moved to PythonBinder.
-  Moved ContextArgBuilder and SiteLocalStorageArgbuilder to Python.
-  ArgBuilder.CanGenerateDelegate needs to be protected so that custom
ArgBuilders can override it.
-  Renames various identifiers to make naming consistent and more
meaningful.
-  Simplifies some methods in MethodBinder and MethodCandidate, removes
dependency on CodeContext - this was only used by JScript (disables a
couple of JS tests).

Ruby:
-  Replaces calls to obsolete methods of default method binder with
those using meta-objects.

Tomas
This topic is locked and can not be replied to.