Forum: IronRuby Review: Marshal bug

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-03-27 02:53
(Received via mailing list)
GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b...

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
'2009-03-22 00:00:00\s\t'") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


 *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b...

Thanks,
Shri
Tomas M. (Guest)
on 2009-03-27 22:18
(Received via mailing list)
Library changes look good.

Tomas

From: Shri B.
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b...

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
'2009-03-22 00:00:00\s\t'") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


 *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b...
 *
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b...

Thanks,
Shri
Jim D. (Guest)
on 2009-03-27 23:27
(Received via mailing list)
Test and batch changes look good.

JD

From: Tomas M.
Sent: Friday, March 27, 2009 12:59 PM
To: Shri B.; IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: RE: Review: Marshal bug

Library changes look good.

Tomas

From: Shri B.
Sent: Thursday, March 26, 2009 4:35 PM
To: IronRuby External Code R.
Cc: removed_email_address@domain.invalid
Subject: Review: Marshal bug

GitDiff.bat a90a89465f3b9c178507f83e4797481463989059
119b056332b270164eaf2b1f9cd2956387e38636
http://github.com/shri/ironruby/commit/119b056332b...

YAML should allow spaces. eg the trailing \s\t in YAML.load("!timestamp
'2009-03-22 00:00:00\s\t'") is allowed
Changed igem.bat, irake.bat, etc to work in dev environment where ir.exe
is not in the path
File.expand_path("~") should throw ArgumentError is HOME is not set


  *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/BaseConstructor.cs<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/External/Languages/IronRuby/Yaml/IronRuby.Libraries.Yaml/Engine/Scanner.cs<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/file/expand_path_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/core/marshal/fixtures/marshal_data.rb<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/External/Languages/IronRuby/mspec/rubyspec/library/yaml/load_spec.rb<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/FileOps.cs<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/Builtins/Marshal.cs<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/igem.bat<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/iirb.bat<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/irails.bat<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/irake.bat<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/irdoc.bat<http://github.com/shri/ironruby/commit/119b056332b...
  *
Merlin/Main/Languages/Ruby/Scripts/bin/iri.bat<http://github.com/shri/ironruby/commit/119b056332b...

Thanks,
Shri
This topic is locked and can not be replied to.