Forum: IronRuby Code Review: scripts

Announcement (2017-05-07): is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see and for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-03-10 19:19
(Received via mailing list)
Attachment: scripts.diff (0 Bytes)
tfpt review "/shelveset:scripts;REDMOND\sborde"

  Comment  :
  Code change:
  Small fix in Shell\CommandLine.cs to deal with newlines consistently
(user-reported issue).

  Moves RunRSpec.cmd and irtests.bat from Merlin\Main\Scripts to
Merlin\Languages\Ruby\Scripts so that they are available in GIT.
  Also changed them so that they do not rely on
Merlin\Main\test\scripts\ir.cmd which does not exist in GIT and is
needed only when Snap runs various modes like with/without
interpretation, etc.
Jim D. (Guest)
on 2009-03-11 01:33
(Received via mailing list)
Ruby Dev.bat:
Can the RUBY19_EXE check for its existence first (so I can override it,
for example). I'd also like to not differentiate between GIT and
non-GIT, with my comment below, we don't need the GIT env. Variable.

I would say get rid of the nested if on line 42. If ROWAN_BIN, use .cmd,
otherwise, use.exe.

Otherwise looks good.

This topic is locked and can not be replied to.