Forum: IronRuby Code Review: numeric types

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Shri B. (Guest)
on 2009-02-26 22:00
(Received via mailing list)
Attachment: num.diff (0 Bytes)
tfpt review "/shelveset:num;REDMOND\sborde"

  Comment  :
  Fixnum + Bignum should yield a Bignum, not a Float. This was causing
complex/denominator_spec to fail as Bignum was monkey-patched and not
Float. A different return type affects whether the monkey-patched method
is visible or not. Also changed fixnum/plus_spec to check for the result
type.
  BigDecimal coercing works a bit differently. So added a protocol for
that.
  Small change to the MSpec eql guard to show the type of actual and
expected values since the inspect string itself can be identical.

Tomas, I had added tests for Enumerable#each_cons each_slice. Let me
know if you want to grab them since you are working on the fix. Else, I
can check it in with tags (will need to move it from library/enumerator
to core/enumerable).
Tomas M. (Guest)
on 2009-02-26 23:41
(Received via mailing list)
Looks good.

Tomas
This topic is locked and can not be replied to.