Forum: Ruby A bug in Ruby regexp lib?

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
ArtÅ«ras Å. (Guest)
on 2009-01-27 20:37
ruby 1.8.7 (2008-08-11 patchlevel 72) [i486-linux]

x11@www:~$ irb
irb(main):001:0> s = "www.myspace.com/djmamania
www.myspace.com/djmantini"
=> "www.myspace.com/djmamania www.myspace.com/djmantini"
irb(main):002:0> s1 = s.gsub(%r{(\s|^)(www\..*?)(\s|$)}m, '\1<a
href="http://\2">\2</a>\3')
=> "<a
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
www.myspace.com/djmantini"
irb(main):003:0> s1.gsub(%r{(\s|^)(www\..*?)(\s|$)}m, '\1<a
href="http://\2">\2</a>\3')
=> "<a
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
<a
href=\"http://www.myspace.com/djmantini\">www.myspace.com...

Why I have to call gsub two times for this to work? Same regexp works
fine in Firefox JS :)
Tim G. (Guest)
on 2009-01-27 21:45
(Received via mailing list)
Artc5abras c5a0lajus wrote:

> ruby 1.8.7 (2008-08-11 patchlevel 72) [i486-linux]
>
> x11@www:~$ irb
> irb(main):001:0> s = "www.myspace.com/djmamania
> www.myspace.com/djmantini"
> => "www.myspace.com/djmamania www.myspace.com/djmantini"
> irb(main):002:0> s1 = s.gsub(%r{(\s|^)(www\..*?)(\s|$)}m, '\1<a
> href="http://\2">\2</a>\3')
> => "<a
>
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
> www.myspace.com/djmantini"
> irb(main):003:0> s1.gsub(%r{(\s|^)(www\..*?)(\s|$)}m, '\1<a
> href="http://\2">\2</a>\3')
> => "<a
>
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
> <a
>
href=\"http://www.myspace.com/djmantini\">www.myspace.com...
>
> Why I have to call gsub two times for this to work? Same regexp works
> fine in Firefox JS :)

Did you mean:

s1 = s.gsub(%r{(^|\s)?(www\..*?)(\s|$)}m, '\1<a
href="http://\2">\2</a>\3')

irb(main):035:0> s1 = s.gsub(%r{(^|\s)?(www\..*?)(\s|$)}m, '\1<a
href="http://\2">\2</a>\3')
=> "<a
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
<a
href=\"http://www.myspace.com/djmantini\">www.myspace.com...

Note the \1 is using (^|\s), as it's either the start of the string (^)
or a white space between the two URLs (\s), but you also have \3, which
is either the end of the string ($) or white space between the URLs (or
following) (\s), and since there's only one white space between the two
URLs, it throws is off.

To account for both \1 and \3, above I've set it to be optional (^|\s)?
because this will allow you to use \3 without is breaking it.  There
are other ways to do this, but just working with what you were using,
that's a change you could make to get the desired results on the first
one... unless I misunderstood what you were trying to do?
Tim G. (Guest)
on 2009-01-27 21:50
(Received via mailing list)
Tim G. wrote:

>> => "<a
>>
>
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
>> www.myspace.com/djmantini"
>> irb(main):003:0> s1.gsub(%r{(\s|^)(www\..*?)(\s|$)}m, '\1<a
>> href="http://\2">\2</a>\3')
>> => "<a
>>
>
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
>> <a
>>
>
href=\"http://www.myspace.com/djmantini\">www.myspace.com...
> href="http://\2">\2</a>\3')
> => "<a
>
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
> <a
>
href=\"http://www.myspace.com/djmantini\">www.myspace.com...
> are other ways to do this, but just working with what you were using,
> that's a change you could make to get the desired results on the first
> one... unless I misunderstood what you were trying to do?

Geez, pardon the typos I've made above.  Apparently I'm having trouble
working my keyboard (some of those "is" should be "it")
ArtÅ«ras Å. (Guest)
on 2009-01-27 22:02
Tim G. wrote:
> Note the \1 is using (^|\s), as it's either the start of the string (^)
> or a white space between the two URLs (\s), but you also have \3, which
> is either the end of the string ($) or white space between the URLs (or
> following) (\s), and since there's only one white space between the two
> URLs, it throws is off.
>
> To account for both \1 and \3, above I've set it to be optional (^|\s)?
> because this will allow you to use \3 without is breaking it.  There
> are other ways to do this, but just working with what you were using,
> that's a change you could make to get the desired results on the first
> one... unless I misunderstood what you were trying to do?

Ah, thank you. It seems that Ruby is parsing that string after getting
last \s down there. But shouldn't \3 insert it right back? :)

Anyways, I have another problem then ;]
it "should link http links" do
  "http://www.myspace.com/djmamania".htmlize.should == \
     '<p><a
href="http://www.myspace.com/djmamania">www.myspace.com/...
end

2)
'String#htmlize should link http links' FAILED
expected: "<p><a
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
ania</a></p>",
     got: "<p>http://<a
href=\"http://www.myspace.com/djmamania\">www.myspace.com...
(using ==)

What do you suggest?
This topic is locked and can not be replied to.