Forum: IronRuby Code Review: VisibilityAndOtherFixes2

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Tomas M. (Guest)
on 2008-11-16 23:11
(Received via mailing list)
Attachment: VisibilityAndOtherFixes2.diff (0 Bytes)
tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
  Comment  :
  Implements
      - private method visibility
      - DATA constant
      - popen and duplex IO streams (will need some refactoring of
RubyIO object)

      Fixes:
      - warnings (verbosity levels, Kernel#warn)
      - Kernel#gets, print, puts (no dynamic call to IO#puts)
      - method reflection: Kernel#methods, Kernel#singleton_methods
(methods were missing in some cases)
      - $~ variable scoping (should be an inner-most non-block scope)
      - inclusion of module already included in a super class was
handled incorrectly

Tomas
Michael L. (Guest)
on 2008-11-17 01:26
(Received via mailing list)
On Sun, Nov 16, 2008 at 4:10 PM, Tomas M. <
removed_email_address@domain.invalid> wrote:

>  tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
>  Comment  :
>  Implements
>      - private method visibility
>
>


*drools*
Curt H. (Guest)
on 2008-11-17 20:39
(Received via mailing list)
Changes look good.
Jim D. (Guest)
on 2008-11-17 20:44
(Received via mailing list)
Test looks good.


JD

From: removed_email_address@domain.invalid
[mailto:removed_email_address@domain.invalid] On Behalf Of Michael
Letterle
Sent: Sunday, November 16, 2008 3:25 PM
To: removed_email_address@domain.invalid
Cc: IronRuby External Code R.
Subject: Re: [Ironruby-core] Code Review: VisibilityAndOtherFixes2


On Sun, Nov 16, 2008 at 4:10 PM, Tomas M.
<removed_email_address@domain.invalid<mailto:removed_email_address@domain.invalid>>
wrote:
 tfpt review "/shelveset:VisibilityAndOtherFixes2;REDMOND\tomat"
 Comment  :
 Implements
     - private method visibility



*drools*
This topic is locked and can not be replied to.