Forum: IronRuby Code Review: RandomRubyFixes05

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Curt H. (Guest)
on 2008-10-24 19:32
(Received via mailing list)
Attachment: RandomRubyFixes05.diff (0 Bytes)
tfpt review "/shelveset:RandomRubyFixes05;REDMOND\curth"

Comment  :
  Factored class IOWrapper.cs out of Marshal and into the Ruby core so
it can be accessed from multiple places
  Factored object creation out of Marshal and into RubyUtils so it can
share code with Yaml
  Disabled name-mangling for symbol "initialize" so that CLR methods
with the name Initialize don't cause trouble
  Implemented String.hex and String.oct
  Modified Socket and StringIO classes so they open in binary mode by
default
  Extensive modifications to zlib:
    Fixed uncompressed blocks to inflate properly
    Reformatted to match standard
    Many small changes to cleanup code and improve performance
    Added support for reading from any object implementing "read" -- not
just IO objects -- by using IOWrapper
  Added an overload to IO.seek that accepts BigInteger.  (This turned
out not to be needed, but the code works.)
  Modified Yaml construction to call yaml_initialize if it exists
Tomas M. (Guest)
on 2008-10-24 21:26
(Received via mailing list)
Looks good.

There is a minor formatting glitch in RubyUtils:

            return new
RubyCompilerOptions(targetScope.ExecutionContext.Context.RubyOptions)
            {
                }

(the opening brace on a new line). I guess you need to set this in VS
formatting options.

Tomas
Oleg T. (Guest)
on 2008-10-24 22:24
(Received via mailing list)
YAML changes look good too.

--
Oleg
This topic is locked and can not be replied to.