Forum: IronRuby Code Review: Copy4

Announcement (2017-05-07): www.ruby-forum.com is now read-only since I unfortunately do not have the time to support and maintain the forum any more. Please see rubyonrails.org/community and ruby-lang.org/en/community for other Rails- und Ruby-related community platforms.
Tomas M. (Guest)
on 2008-10-11 05:44
(Received via mailing list)
Attachment: Copy4.diff (0 Bytes)
tfpt review "/shelveset:Copy4;REDMOND\tomat"

  Implements initialize_copy for built-in classes.
  Removes assertion in Proc, it was wrong.
  Improves and fixes Kernel#send.
  Implements default protocol for to_ary conversion.
  Fixes super call with a block but no other arguments.

  Fixes bugs:
  [#20849] instance_eval within class_eval causes incorrect method
lookup.
  [ ironruby-Bugs-20317 ] Kernel#instance_eval.
  [ ironruby-Bugs-20705 ] instance_eval allows defining methods on all
objects
  [ ironruby-Bugs-20408 ] TRUE, FALSE & NIL not defined.
  [ ironruby-Bugs-21942 ] a const defined on a metaclass is not
preserved when the object is cloned

Tomas
Curt H. (Guest)
on 2008-10-13 07:18
(Received via mailing list)
The KernelOps._sites dictionary never

There's at least one "#region IRubyCloneableMembers" in RubyObject.cs
which should be renamed. (There may be others.)

Some of the comments in RubyModule.Subclass.cs weren't edited after they
were copied from MutableString.Subclass.c
Curt H. (Guest)
on 2008-10-13 07:28
(Received via mailing list)
Sorry about the premature send.  I blame the keyboard. ;)

Changes are good. Four comments:

1. The KernelOps._sites dictionary never has the opportunity to have
something removed from it; this worries me a little.
2. There's at least one "#region IRubyCloneableMembers" in RubyObject.cs
which should be renamed. (There may be others.)
3. Some of the comments in RubyModule.Subclass.cs weren't edited after
they were copied from MutableString.Subclass.cs.
4. There was a trivial change to DLR outer ring that should probably
have been copied to dlrcr.
Tomas M. (Guest)
on 2008-10-13 21:36
(Received via mailing list)
2,3,4) fixed.

1) Yes, it's potential issue, however DLR doesn't clear rule cache
either. I'll follow up.
This topic is locked and can not be replied to.