Forum: Rails-core (closed, excessive spam) ActiveSupport::Dependencies does not exist on branch

Posted by acechase (Guest)
on 2008-06-09 22:36
(Received via mailing list)
This commit seems to have broken the stable 2-1 branch:
http://github.com/rails/rails/commit/cce30f71246db...

I think it should not have been committed to the branch because on the
branch lib/active_support/dependencies.rb does not yet have its module
namespace wrapped with the ActiveSupport namespace (looks like that's
only on the trunk). fwiw, I'm looking at this version of
dependencies.rb
http://github.com/rails/rails/tree/cce30f71246dbc5...

Am I confused here? When I look at the dependencies.rb file on the
tree attached to that commit it looks like it does not have the
ActiveSupport namespace wrapped around it, but I'm hesitant to call it
a bug because it seems like this would have been picked up in the
simplest of tests (it fails for me on loading script/console).

Cheers,

Andrew
Posted by acechase (Guest)
on 2008-06-09 22:38
(Received via mailing list)
p.s. running: "git revert cce30f71246dbc5433153156afa4f952553ad13d"
fixes the problem.
Posted by Rob Sanheim (rsanheim)
on 2008-06-09 23:41
(Received via mailing list)
I posted on this a few days back and also created a ticket:

http://rails.lighthouseapp.com/projects/8994-ruby-...

- rob

http://robsanheim.com
Posted by Jeremy Kemper (Guest)
on 2008-06-09 23:52
(Received via mailing list)
On Mon, Jun 9, 2008 at 2:40 PM, Rob Sanheim <rsanheim@gmail.com> wrote:
>
> I posted on this a few days back and also created a ticket:
>
> http://rails.lighthouseapp.com/projects/8994-ruby-...

Thanks for the heads-up, guys. Josh merged the missing commits over to
2-1-stable.

jeremy
This topic is locked and can not be replied to.