Forum: Rails-core (closed, excessive spam) Partial counters starting value changed

Posted by Frederick Cheung (Guest)
on 2008-06-01 22:16
(Received via mailing list)
Over on ruby on rails talk, Eric Ly noted that partial counters now
begin at 1 instead of 0.
As far as I can tell this is because previously the counter value came
straight out of each_with_index. However now the PartialTemplate
starts off with a counter value of 0 and we += it before the render.
Unfortunately it doesn't look like there was a test for this in 2.0 so
it's not surprising this snuck through.
Can it be put back to the way it was or is the disruption of it
changing a second time in 2.1.x more trouble than it's worth?

Fred
Posted by Michael Koziarski (Guest)
on 2008-06-03 20:41
(Received via mailing list)
> Can it be put back to the way it was or is the disruption of it
> changing a second time in 2.1.x more trouble than it's worth?

Yeah, it should be reverted to start at zero just like it used to.
Open a lighthouse ticket for it and we'll get it into 2.1.1


--
Cheers

Koz
Posted by Frederick Cheung (Guest)
on 2008-06-05 22:01
(Received via mailing list)
On 3 Jun 2008, at 19:40, Michael Koziarski wrote:

>
>> Can it be put back to the way it was or is the disruption of it
>> changing a second time in 2.1.x more trouble than it's worth?
>
> Yeah, it should be reverted to start at zero just like it used to.
> Open a lighthouse ticket for it and we'll get it into 2.1.1
>
did that here: 
http://rails.lighthouseapp.com/projects/8994-ruby-...

Fred
This topic is locked and can not be replied to.