Ruby Forum IronRuby > Code Review: Reflection

Posted by Tomas Matousek (Guest)
on 08.05.2008 21:02
Attachment: Reflection.diff (25,7 KB)
(Received via mailing list)
tfpt review /shelveset:Reflection;REDMOND\tomat

Removes singleton classes from Module#ancestors return value to match 
MRI.
Implements Kernel#extend, Kernel#singleton_methods, Module#extended and 
Module#extend_object.

Fixes [#20002] singleton_methods not implemented.
Fixes [#19972] Module::module_function assertion error. The assertion 
was incorrect.
Fixes [#20011] Can't subclass module. Added protected constructors to 
allow inheriting in Ruby.

Includes adjusted Wayne Kelly's patch.

Tomas
Posted by Dino Viehland (Guest)
on 09.05.2008 02:16
(Received via mailing list)
I think you also need to check for ci.IsFamilyAndAssembly in 
RubyTypeBuilder.MakeClass (when checking for private) but otherwise it 
looks good.
Posted by Tomas Matousek (Guest)
on 09.05.2008 02:28
(Received via mailing list)
Thanks, forgot about that one.

Tomas