Ruby Forum Ruby-Gnome 2 > [patch] Use G_CHILD_ADD when adding elements and pads

Hi,

  See attached patch.

  Sjoerd

On Sat, Mar 29, 2008 at 09:53:48PM +0100, Sjoerd Simons wrote:
> Hi,
> 
>   See attached patch.

Which contained some typos, updated patch attached

  Sjoerd

Hi,

In <20080329211451.GA14792@spring.luon.net>
  "Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding 
elements and pads" on Sat, 29 Mar 2008 22:14:51 +0100,
  Sjoerd Simons <sjoerd@luon.net> wrote:

> >   See attached patch.
> 
> Which contained some typos, updated patch attached

It was very happy for us if you considered to follow our
coding-style.

> +    if (!rb_obj_is_kind_of (element, klass)) {

Use RVAL2CBOOL not !.


Others are OK for me.


Thanks,
--
kou

On Sun, Mar 30, 2008 at 09:04:23AM +0900, Kouhei Sutou wrote:
> It was very happy for us if you considered to follow our
> coding-style.

You mentioned this on all my patches. But as i'm still unclear what the 
exact
coding style is i'm guessing from various files and it seems i'm 
guessing wrong
:) It would really help me if you could write some basic definition of 
your
preferred coding style.

> > +    if (!rb_obj_is_kind_of (element, klass)) {
> 
> Use RVAL2CBOOL not !.

Actually the ruby interpreter code itself uses !rb_obj_is_kind_of too, 
but i'll
change this :)

  Sjoerd
--
If I have not seen so far it is because I stood in giant's footsteps.

Hi,

In <20080330002916.GA18305@spring.luon.net>
  "Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding 
elements and pads" on Sun, 30 Mar 2008 01:29:16 +0100,
  Sjoerd Simons <sjoerd@luon.net> wrote:

> You mentioned this on all my patches. But as i'm still unclear what the exact
> coding style is i'm guessing from various files and it seems i'm guessing wrong
> :) It would really help me if you could write some basic definition of your
> preferred coding style.

Does this mean "I can't read source codes written by
others", "I don't want to read source codes written by
others carefully" or "I don't want to follow your
coding-style"? If this is true, unfortunately we will not be
able to work on the same project.

You can read many source files in the Ruby-GNOME2 Project or
ruby itself or use Emacs just for confirming coding-style.


Thanks,
--
kou

On Sun, Mar 30, 2008 at 03:54:47PM +0900, Kouhei Sutou wrote:
> 
> Does this mean "I can't read source codes written by
> others", "I don't want to read source codes written by
> others carefully" or "I don't want to follow your
> coding-style"? If this is true, unfortunately we will not be
> able to work on the same project.

It means none of the above. It means that as far as i can tell the patch 
i've
attached in this thread follows the coding style which is in most other
rubyg-gnome2 files (excluding ruby/gstreamer as that's mostly a mess). 
But
apparently i got some details wrong. So please instead of telling me 
that
something is wrong, tell me what is wrong so i can fix it and improve it 
in the
other patches too.

The bigger patches might have more obvious things wrong, i haven't 
double-check
them just yet. But i can't find mistakes in the patch i attached in this
thread.

  Sjoerd
--
FORTUNE'S FUN FACTS TO KNOW AND TELL:    #44
  Zebras are colored with dark stripes on a light background.

Hi,

In <20080330093532.GA2712@spring.luon.net>
  "Re: [ruby-gnome2-devel-en] [patch] Use G_CHILD_ADD when adding 
elements and pads" on Sun, 30 Mar 2008 11:35:32 +0200,
  Sjoerd Simons <sjoerd@luon.net> wrote:

> 
> It means none of the above. It means that as far as i can tell the patch i've
> attached in this thread follows the coding style which is in most other
> rubyg-gnome2 files (excluding ruby/gstreamer as that's mostly a mess). But
> apparently i got some details wrong. So please instead of telling me that
> something is wrong, tell me what is wrong so i can fix it and improve it in the
> other patches too.

OK. I will trust you once.

You can commit your patches that I've reviewed without
fixing your style. I'll fix your style after you commit.
But you need to check my fixes, learn from my commits and
follow our coding-style in the feature commit. OK?


Thanks,
--
kou