Ruby Forum Ruby-Gnome 2 > [patch] Ensure correct refcounting on Gst::ElementFactory.make

Hi,

   See patch for details. I was unsure which coding-style to use here. I 
picked
   the one already used in this file to minimize white-space diffs and 
prevent
   coding style inconsitency inside one function.

  Sjoerd

Hi,

In <20080329165539.GA18371@beast.luon.net>
  "[ruby-gnome2-devel-en] [patch] Ensure correct refcounting on 
Gst::ElementFactory.make" on Sat, 29 Mar 2008 17:55:39 +0100,
  Sjoerd Simons <sjoerd@luon.net> wrote:

>    See patch for details. I was unsure which coding-style to use here. I picked
>    the one already used in this file to minimize white-space diffs and prevent
>    coding style inconsitency inside one function.

Use GOBJ2RVAL_UNREF() for this.

Please fix coding-style after fix the problem.


Thanks,
--
kou

On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei Sutou wrote:
> Use GOBJ2RVAL_UNREF() for this.
> 
> Please fix coding-style after fix the problem.

Committed with that changed and the function in hopefully fixed 
coding-style :)

  Sjoerd
--
What is now proved was once only imagin'd.
    -- William Blake

Hi,

In <20080405163918.GB18313@spring.luon.net>
  "Re: [ruby-gnome2-devel-en] [patch] Ensure correct refcounting on 
Gst::ElementFactory.make" on Sat, 5 Apr 2008 18:39:18 +0200,
  Sjoerd Simons <sjoerd@luon.net> wrote:

> On Sun, Mar 30, 2008 at 08:31:07AM +0900, Kouhei Sutou wrote:
> > Use GOBJ2RVAL_UNREF() for this.
> > 
> > Please fix coding-style after fix the problem.
> 
> Committed with that changed and the function in hopefully fixed coding-style :)

I've fixed coding-style. Please confirm that and commit all
your reviewed patches. You don't need to care coding-style
at present. I'll fix. It seems that Ruby/GStreamer blocks
Joachim's work.


Thanks,
--
kou