Ruby Forum Ruby-Gnome 2 > [patch] Sink floating gstreamer objects

Hi,

  Attached is the first patch in my patchset intended to merge both 
current
  gstreamer bindings into one with the best of both :) Please review and 
let me
  know if it's ok to commit?

  See the patch itself for details. It does make me wonder if
  rbgobj_get_value_from_gobject shouldn't be in rbgst.h instead of
  rbgprivate.h? Because at this point it's not possible to compile the
  gstreamer bindings without having the glib2 source.

  Sjoerd
PS: For those who wondering i'm using git-svn for my patch management, 
which
shows up in the diff. But it doesn't make any difference when committing 
to
svn.

>  PS: For those who wondering i'm using git-svn for my patch management, which

Interesting. Do you have any pointer explaining the advantages of doing 
so?

--
Guillaume Cottenceau - http://zarb.org/~gc/

On Sat, Mar 29, 2008 at 07:00:40PM +0100, Guillaume Cottenceau wrote:
> >  PS: For those who wondering i'm using git-svn for my patch management, which
> 
> Interesting. Do you have any pointer explaining the advantages of doing so?

See http://www.kernel.org/pub/software/scm/git/docs/git-svn.html for a
description of git-svn. The advantages of doing so is basically get all
advantages of using a DVCS while the main branch is still in svn. I'm 
sure you
can find more then enough articles on the web describing the advantages 
of a
DVCS. But what is most important for me is that i can commit patches 
locally
and then after review can push them upstream without loosing meta-data

  Sjoerd
--
Everything that can be invented has been invented.
    -- Charles Duell, Director of U.S. Patent Office, 1899

Hi,

In <20080329160434.GA6461@spring.luon.net>
  "[ruby-gnome2-devel-en] [patch] Sink floating gstreamer objects" on 
Sat, 29 Mar 2008 17:04:34 +0100,
  Sjoerd Simons <sjoerd@luon.net> wrote:

>   See the patch itself for details. It does make me wonder if
>   rbgobj_get_value_from_gobject shouldn't be in rbgst.h instead of
>   rbgprivate.h? Because at this point it's not possible to compile the
>   gstreamer bindings without having the glib2 source.

I've exported the function.

>  #define GST_TAG_LIST_STRUCTURE_NAME   "taglist"
Don't export rbgst_object_instance2robj(). Use
rbgst-private.h. Others are OK for me.


Thanks,
--
kou

Sjoerd Simons wrote:
> On Sat, Mar 29, 2008 at 07:00:40PM +0100, Guillaume Cottenceau wrote:
>> >  PS: For those who wondering i'm using git-svn for my patch management, which
>> 
>> Interesting. Do you have any pointer explaining the advantages of doing so?
> 
> See http://www.kernel.org/pub/software/scm/git/docs/git-svn.html for a
> description of git-svn. The advantages of doing so is basically get all
> advantages of using a DVCS while the main branch is still in svn. I'm 
> sure you
> can find more then enough articles on the web describing the advantages 
> of a
> DVCS. But what is most important for me is that i can commit patches 
> locally
> and then after review can push them upstream without loosing meta-data
> 
>   Sjoerd
> --
> Everything that can be invented has been invented.
>     -- Charles Duell, Director of U.S. Patent Office, 1899

Hi Sjoerd,

Nice. I'm very interested. What changes are you going to make? iow: what 
are the advantages of the "other" ruby gstreamer bindings?

Oh, and welcome to the cool-kid git club :)

On Sun, Mar 30, 2008 at 08:27:21AM +0900, Kouhei Sutou wrote:
> 
> > +
> > 
> >  #define GST_TAG_LIST_STRUCTURE_NAME   "taglist"
>  
> Don't export rbgst_object_instance2robj(). Use
> rbgst-private.h. Others are OK for me.

Ok comitted with that change

  Sjoerd
--
In 1750 Issac Newton became discouraged when he fell up a flight of 
stairs.