Forum: Rails Engines development Engines 2.0/trunk with Rails 2.0

Hi,

i'm gald to hear, that Engines make steps
towards Rails 2.0, so i'm able to port my redMine
plugins now ;o)

in my first test, i found these 2 bugs:

1)
the 'rake test:plugins:all PLUGIN=xxx' task abort with an Error
(full path shorted and replaced with <...>)

** Invoke test:plugins:units (first_time)
** Invoke test:plugins:setup_plugin_fixtures (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute test:plugins:setup_plugin_fixtures
rake aborted!
undefined method `mirror_files_from' for Engines:Module
<...>/vendor/plugins/engines/lib/engines/testing.rb:74:in 
`setup_plugin_fixtures'
<...>/vendor/plugins/engines/lib/engines/testing.rb:71:in `each'
<...>/vendor/plugins/engines/lib/engines/testing.rb:71:in 
`setup_plugin_fixtures'
<...>/vendor/plugins/engines/tasks/engines.rake:143


2)
if i reload a view from a plugin-based controller, i get the following
error every time:

A copy of ApplicationController has been removed from the module tree 
but is still active!
/usr/lib/ruby/gems/1.8/gems/activesupport-2.0.1/lib/active_support/dependencies.rb:237:in 
`load_missing_constant'
/usr/lib/ruby/gems/1.8/gems/activesupport-2.0.1/lib/active_support/dependencies.rb:469:in 
`const_missing'
app/controllers/application.rb:31:in `user_setup'



i don't found a working ticket-system for rails-engines, so i think
this list is the best way to report. please correct me, if i'm wrong.
if you need some more info's, please let me know.

thanks for your work
Ralph

Hi Ralph,

Am 10.12.2007 um 22:09 schrieb Ralph Vater:
> undefined method `mirror_files_from' for Engines:Module
> <...>/vendor/plugins/engines/lib/engines/testing.rb:74:in  
> `setup_plugin_fixtures'

I guess I've missed the fact that this method is used here (a test
case is also missing). mirror_files_from is now a method on
Engines::Assets, which of course doesn't make a lot of sense. I guess
it should be moved back to the Engines module or probably an
Engines::Filetools module that communicates the purpose of this method?

> app/controllers/application.rb:31:in `user_setup'
Not sure about this one. But it's probably unrelated to Engines itself
but related to the fact that Engines now rely on Rails' own plugin
mechanisms. I seem to remember that I've seen an error like this when
references to a class are saved somewhere and the class then gets
reloaded in development mode while the reference holding object
doesn't. Is that the case here? Does your application somehow save a
reference of the ApplicationController?

Thanks for the report!


--
sven fuchs      svenfuchs@artweb-design.de
artweb design    http://www.artweb-design.de
grünberger 65    + 49 (0) 30 - 47 98 69 96 (phone)
d-10245 berlin    + 49 (0) 171 - 35 20 38 4 (mobile)

>> undefined method `mirror_files_from' for Engines:Module
>> <...>/vendor/plugins/engines/lib/engines/testing.rb:74:in
>> `setup_plugin_fixtures'
> it should be moved back to the Engines module


I've done this.

http://svn.rails-engines.org/engines/trunk/lib/engines.rb
http://svn.rails-engines.org/test/engines/rails_2....



--
sven fuchs      svenfuchs@artweb-design.de
artweb design    http://www.artweb-design.de
grünberger 65    + 49 (0) 30 - 47 98 69 96 (phone)
d-10245 berlin    + 49 (0) 171 - 35 20 38 4 (mobile)