Forum: Rails Engines engines and edge rails

Hi there,

We're using engines heavily in our current app - problem is that we've
seen the lovely patch DHH just committed to edge rails to allow easy
namespacing of routes (
http://railstips.org/2007/4/28/namespaces-added-to-routes ). We'd really
like to move to edge to take advantage of this but we're so heavily
dependant on the current release of engines that we can't afford to
break that.

So - anyone know of any issues with edge rails and the current stable
release of engines? Would we have to move over to an edge version of
engines as well?

Cheers,

David

Hi,

On Apr 30, 2007, at 5:24 AM, David Smalley wrote:
> release of engines? Would we have to move over to an edge version of
> engines as well?

When I was first trying out engines a few weeks ago, I tested it with
edge.  At the time, it wouldn't work.  I tracked the problem back to
this edge change:

http://dev.rubyonrails.org/changeset/6277

At the time, the engines trunk didn't have a fix, but it could have
one now.  (I've since been using rails 1.2.3 with the 1.2-stable
branch of engines, so I'm not keeping up with this.)

Rhett

Rhett Sutphin wrote:
> When I was first trying out engines a few weeks ago, I tested it with
> edge.  At the time, it wouldn't work.  I tracked the problem back to
> this edge change:
> 
> http://dev.rubyonrails.org/changeset/6277

A-ha - I've been fiddling around this morning and it looks like this is 
what's causing the error for me as well. This was when trying edge rails 
with stable engines 1.2.

Has this been fixed in edge engines? Can we expect any compatibility or 
am I well worth leaving this alone until Rails 1.2.4? - I really would 
like to use the name space routing :-D

The biggest problematic change in Edge Rails that will affect engines
is the new plugin loading mechanism, which will conflict with the way
that the engines plugin (see a post on this thread by Rhett for the
specific changeset).

Because we don't develop against Edge at work (in general), we've not
needed to deal with this problem yet. It requires some thought because
the direction core has taken the plugin loading mechanism doesn't suit
my needs. In a nutshell, do provide a new "PluginLoader" class, that
class needs to be available on the load path before the initializer
starts up. That's going to mean either repackaging the engines plugin
as a gem and adding "gem 'engines'" to the top of environment.rb, or
some other dastardly hack. I'm still undecided. Any thoughts?

It's worth noting that until there's a pressing need here for the
plugin to work with Edge rails, it won't get much attention, but if
any of you have the need, please do discuss possible approaches, and
submit patches! http://dev.rails-engines.org/ is your playground!

Cheers,

James

Further more, please post any good ideas here:
http://dev.rails-engines.org/engines-plugin/tickets/267

Hi James,
  I'd like to get a patch together so that Engines will once again work 
in Edge.  I see that there is a trunk in subversion that was updated 7 
months ago and a 1.2 branch that is more recent.  I also see that though 
there are tests in the trunk they are not found in the branch.  Which 
one should I develop my patch off of?

Thanks,
Rob Kaufman
James Adam wrote:
> Further more, please post any good ideas here:
> http://dev.rails-engines.org/engines-plugin/tickets/267

Has anyone got engines working with edge yet?

I'm freaking out over here trying to get TzTime rolling (which requires 
edge).

It'd be great to see something. Anyone patched the code yet?

I posted this a little while ago to the ruby-forum, but never heard 
back.  I
have a copy of engines working on Edge (at least edge as of a few weeks 
ago)
but as I'm not sure which repository is the current HEAD I don't know 
where
to patch against.

Hi James,
  I'd like to get a patch together so that Engines will once again work
in Edge.  I see that there is a trunk in subversion that was updated 7
months ago and a 1.2 branch that is more recent.  I also see that though
there are tests in the trunk they are not found in the branch.  Which
one should I develop my patch off of?

Thanks,
Rob Kaufman

Hi Rob,

Sorry - I must've missed your message (I don't know how reliably the
ruby-forum is at passing things through...?). Anyway:

Until about 5 minutes ago, the HEAD was in branches/rb_1.2 - I had
postponed merging anything into the trunk, because I hadn't yet
decided how to tackle some of the more significant changes in edge
Rails. However, I've just replaced the trunk with a copy of
branches/rb_1.2 - please use this to develop your patches.

Thanks,

James